Forms

form_embed.js Hides Third-Party Iframes Due to Overly Broad URL Pattern Matching
Summary The form_embed.js script (included with form/calendar embeds) unintentionally hides third-party iframes on the same page when their src URL contains path segments like /booking, /form, /survey, /quiz, /group, /rentals, or /service-menu. Steps to Reproduce Embed a GHL form or calendar on a page that also contains a third-party iframe Ensure the third-party iframe src contains any of the above path segments (e.g. an Office 365 booking page at https://outlook.office365.com/owa/calendar/.../bookings/ ) Load the page Expected Behavior form_embed.js should only affect GHL-owned iframes and leave all third-party iframes untouched. Actual Behavior The Me() function in form_embed.js uses broad string matching (e.g. src.includes("/booking")) to identify GHL iframes. Any third-party iframe whose src URL happens to contain one of these path segments is incorrectly identified as a GHL iframe. It is then hidden via display:none / visibility:hidden by the de() function during initialization and never shown again, because it never sends the expected iframeLoaded postMessage that GHL uses to trigger the show sequence. Affected URLs / Example Third-party iframe src: https://outlook.office365.com/owa/calendar/***/bookings/ Matches because: src.includes("/booking") returns true Root Cause The Me() / Ie() filter in form_embed.js identifies GHL iframes purely by URL path segment pattern matching rather than by origin domain or a dedicated HTML attribute. This is not specific enough to distinguish GHL iframes from third-party iframes. Workaround A client-side interval loop is required to repeatedly force the hidden iframe back to visible after GHL's script runs, which is not a sustainable solution. Please let me know if you need any additional detail or a reproduction case.
0
·
Bug
Correct/Set Field validation Messages in Forms (email, phone, etc.)
The validation messages when filling out a form are unusual/non-standard for forms, such as the email field. I would consider this a bug. Example: Email field. If you enter an invalid email, the validation message says "Guest email is invalid" but this is an unusual message for this. It should be something akin to "Please enter a valid email address." A message like "Please enter a valid email address" applies to both leaving the required field empty AND the email being invalid. The best solution to this overall would just be to allow us to set the validation error message ourselves. In general we should be able to set custom validation messages on each field, so this is also an enhancement. Example 2: Checkboxes. If I have a checkbox field that requires at least one to be checked, the validation message is not very good. Let's say I have a checkbox field called "Subscribe to" and the two boxes are "Newsletter" and "Podcast." If neither are selected, the message will be "Subscribe to is required." This is technically correct, the field is called "Subscribe to," but it would be much better if a custom validation message could be set to say "Please select at least one option." I have seen this ability in other form builders, such as Forminator, where a custom validation message can be set. At the very least, it should be easier to change this. Currently, it requires a fair amount of custom code in an html element that uses css and javascript. Due to the html element not allowing anonymous functions anymore it is quite a bit of lines of code to cover all the bases.
0
·
Bug
Load More